lsm / neokai / 28135756192

82%

push

github

docs: encode event-age TTL anchor for persisted pending external deliveries (#2173)

The TTL for DB-persisted pending external-event deliveries is anchored to the
external event's creation/ingestion time (source-event row created_at), not
the delivery row's registration time. This was the intended design (design
doc §5: 'Event TTL: Events older than 5 minutes are dropped') and is already
implemented consistently across both persisted paths
(collectPersistedPendingDeliveries and the rehydrate retry sweep, both reading
eventRecord.createdAt). The delivery table intentionally has no created_at
column.

This change encodes the decision in code so it is not re-litigated:
- Document the TTL anchor at EXTERNAL_EVENT_QUEUE_TTL_MS (canonical),
  isQueuedExternalEventExpired, and both persisted-path anchor points.
- Add a regression test for the delayed-registration discriminator: a
  delivery registered 'now' for an already-stale event still expires on the
  activation flush. This would fail if the anchor were switched to
  registration age.

11362 of 16393 branches covered (69.31%)

Branch coverage included in aggregate %.

95311 of 113566 relevant lines covered (83.93%)

300.39 hits per line