ultimate-notion / ultimate-notion / 27943430721

87%

push

github

Replace cast downcasts with isinstance guards in core and session (#264)

Remove four `cast` downcasts, replacing each with an `isinstance` guard
that narrows for the type checker and raises `TypeError` otherwise,
matching the existing narrowing idiom (e.g. the sibling `_cache_get`):

- `Wrapper.wrap_obj_ref` collapses both branches onto a single `hl_obj`,
  then narrows it to `Self` via `isinstance(hl_obj, cls)` (`cls` is
  `type[Self]`), covering both the direct-build and recursive-resolve
  cases. Drops two `cast(Self, ...)` calls.
- `Session._cache_add` narrows the `setdefault` result with
  `isinstance(cached, type(obj))`, mirroring `_cache_get`.

Both files can now drop their unused `cast` import.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

8 of 12 new or added lines in 2 files covered. (66.67%)

6584 of 7541 relevant lines covered (87.31%)

6.08 hits per line