ultimate-notion / ultimate-notion / 27945208756

87%

push

github

Replace cast(Self, model_construct(...)) with isinstance guards in props (#266)

Remove four `cast(Self, ...)` downcasts from the `build` classmethods in
`obj_api/props.py`, replacing each with an `isinstance(obj, cls)` guard
that narrows `model_construct`'s result to `Self` for the type checker and
raises `TypeError` otherwise, matching the existing narrowing idiom
introduced for `wrap_obj_ref` and `_cache_add`.

The pydantic mypy plugin types `model_construct` as returning the concrete
class rather than `Self`, so the casts were not redundant; the guard
preserves the type narrowing without a `cast`. The file can now drop its
unused `cast` import.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

13 of 21 new or added lines in 1 file covered. (61.9%)

6592 of 7557 relevant lines covered (87.23%)

6.08 hits per line