ultimate-notion / ultimate-notion / 27923030995

87%

Build Type

push

github

Committed by web-flow

Commit Message

Replace cast downcasts in blocks.py with isinstance guards (#263)

Remove three `cast` downcasts in `blocks.py`, replacing each with an
`isinstance` guard that raises `TypeError` (matching the existing
narrowing idiom, since ruff S101 disallows asserts in source):

- `ChildrenMixin.append` narrows `self` to `Block | Page` once via a
  local, replacing both `cast(Block, self)` and `cast(ParentBlock, self)`.
  The old `ParentBlock` cast also misrepresented the `Page` case, since
  `Page` also subclasses `ChildrenMixin` and `_chunk_blocks_for_api`
  accepts `Block | Page`.
- `Block.parent` narrows `super().parent` to `Block | Page | None`.

This lets the now-unused `cast` import be dropped.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

10 of 14 new or added lines in 1 file covered. (71.43%)

1 existing line in 1 file now uncovered.

6581 of 7534 relevant lines covered (87.35%)

6.09 hits per line