supabase / supabase-flutter / 27911656760

85%

push

github

chore(supabase_lints): enable avoid-unnecessary-nullable return-type & parameters (#1429)

Stacked on #1427.

## What

Enables `avoid-unnecessary-nullable-return-type` and
`avoid-unnecessary-nullable-parameters`. Per the v3 split in #1428, this
PR only does the **non-breaking** fixes; genuinely breaking changes stay
deferred to v3.

### Fixed (9 sites, all non-breaking / internal)
- `storage_client` `_parseMediaType` -> returns non-null `MediaType`
(`MediaType.parse` never returns null).
- `supabase_flutter` `_widgetsBindingInstance` -> non-null
`WidgetsBinding`; the two callers drop the now-redundant `?.` (modern
Flutter's `WidgetsBinding.instance` is non-null).
- `supabase` `_initSupabaseAuthClient` -> `required bool
autoRefreshToken` (the sole caller always passes
`AuthClientOptions.autoRefreshToken`, a non-null `bool`).
- `supabase` + `supabase_flutter` `platform_io.dart`: `condPlatform` /
`condPlatformVersion` / `condRuntimeVersion` -> non-null. The IO
implementation never returns null; the conditional-import stub stays
nullable (web can be null), and the public `Constants.platform` is
unchanged (`String?`).

### Inline ignores (2 — nullability is required, not unnecessary)
- `supabase_flutter` `local_storage_stub.accessToken`: the throw-stub
must keep `String?` to match the web implementation
(`localStorage.getItem` is nullable).
- `postgrest` `_copyWithType`'s `headers` parameter: relies on `null`
(the default) to fall back to `?? _headers`; making it non-null would
change behavior.

## Verification
- `dcm analyze packages` -> no issues found (including no
unused-ignores).
- `dart analyze` clean (lib + test) across packages; `flutter analyze
--fatal-warnings` clean.
- Tests: supabase 83 pass, supabase_flutter 49 pass. (One mock-server
stream test flaked on a 30s timeout once, passed on re-run; the
platform-metadata test exercising the `platform_io` change passes.)

## Note
The genuinely breaking nullable-related changes are tracked in #1428
(ad... (continued)

10 of 10 new or added lines in 4 files covered. (100.0%)

4078 of 4788 relevant lines covered (85.17%)

3.49 hits per line