supabase / supabase-flutter / 27912358077

85%

push

github

chore(supabase_lints): enable prefer-correct-json-casts (#1430)

Stacked on #1429.

## What

Enables `prefer-correct-json-casts`, which warns that casting a decoded
value directly to a concrete generic type (e.g. `as List<Presence>`, `as
Map<String, String>`) can throw at runtime. The fix follows the rule's
recommendation: cast through a non-generic type first, then narrow the
elements.

- `functions_client`: `body as Map<String, String>?` -> `(body as
Map?)?.cast<String, String>()`
- `realtime_client` presence payloads
(`RealtimePresenceJoinPayload`/`LeavePayload.fromJson`):
`json['newPresences'] as List<Presence>` -> `(json['newPresences'] as
List).cast()` (the element type is inferred from the constructor
parameter, so no explicit `<Presence>` to keep
`avoid-inferrable-type-arguments` happy).

## Behavior-preserving

These are not bug fixes, just safer casts:
- The presence lists are built client-side as `List<Presence>` (via
`RealtimePresence._transformState`; `state` is `Map<String,
List<Presence>>`), so the original cast worked at runtime; `.cast()`
preserves that.
- The functions `body` is asserted to be a `Map<String, String>` (or
null) just above.

## Verification
- `dcm analyze packages` -> no issues found.
- `dart analyze` clean (lib + test) for functions_client and
realtime_client.
- Tests: functions_client 36 pass, realtime_client
(channel/socket/mock/transformers) 101 pass.

5 of 5 new or added lines in 2 files covered. (100.0%)

4079 of 4789 relevant lines covered (85.17%)

3.49 hits per line