supabase / supabase-flutter / 27911371337

85%

push

github

chore(supabase_lints): enable avoid-shadowing (#1427)

Stacked on #1426.

## What

Enables `avoid-shadowing` by renaming the 52 inner identifiers that
shadowed an outer field, getter, or variable.

### lib (real field/getter shadows)
- `postgrest` / `storage_file_api`: local `url` -> `requestUrl`
(shadowed the `url` getter).
- `supabase_client`: setter param `headers` -> `newHeaders`; local
`headers` -> `mergedHeaders`.
- `realtime_client`: `channel` positional `params` -> `config`;
`onConnMessage` local `ref` -> `messageRef`;
`endPointURL`/`_appendParams` `params` -> `queryParams`.
- `realtime_channel`: local `presence` -> `presenceConfig`; `isMember`
param `topic` -> `otherTopic`.
- `push`: params `timeout`/`payload` -> `newTimeout`/`newPayload`;
callback `(payload, [ref])` -> `(response, [_])`.
- `realtime_presence`: closure `presences` -> `pres`.
- `gotrue_client`: locals `currentSession` -> `existingSession`; closure
params `(jwk)` -> `(key)`, `(event)` -> `(e)`.

### tests
Per-test locals that shadowed `setUp`/group variables were renamed
(`postgrest`/`storage`/`supabase`/`client`/`socket`/`channel` locals),
websocket-message closure params `request` -> `message`, and the `on`
group's redundant `late RealtimeChannel channel` was dropped to reuse
the outer one.

### inline ignore (breaking to rename)
- `functions_client.invoke`'s public `headers` named parameter keeps an
`// ignore: avoid-shadowing` — renaming it would break callers.

## Verification
- `dcm analyze packages` -> no issues found.
- `dart analyze` clean across all packages (lib + test); `flutter
analyze --fatal-warnings` clean.
- Tests: realtime socket/channel/mock/transformers 101 pass, postgrest
retry+stack_trace 17, supabase_flutter 49. Pure refactor
(compiler-verified rename); server-dependent integration tests
unaffected.

43 of 46 new or added lines in 8 files covered. (93.48%)

4078 of 4788 relevant lines covered (85.17%)

3.49 hits per line