supabase / supabase-flutter / 27771763312

85%

push

github

chore(supabase_lints): enable avoid-default-tostring (#1426)

Stacked on #1425.

## What

Enables the `avoid-default-tostring` rule, which flags relying on
`Object.toString()` (the unhelpful `Instance of 'X'`). All 18 sites were
one of:

- **Genuine fix** — `User.toString()` interpolated its `List<Factor>`,
and `Factor` had no `toString`, so it rendered as `Instance of
'Factor'`. Added a `toString` to `Factor`.
- **Enums in messages / data-class `toString`** — rendered with `.name`
(e.g. `flowType: ${_flowType.name}`, `event: ${event.name}`) instead of
relying on the default. Affects log lines and the `toString` of
`AuthState`, `RealtimeSubscribeException`, `PostgresChangePayload`,
`PresencePayload`, `PresenceSyncPayload`. No tests assert on these
formats.
- **Logic** — `convertCell` matched a `PostgresTypes` value via
`e.toString() == 'PostgresTypes.$type'`; changed to `e.name == type`
(equivalent, no default-`toString` reliance).
- **Removed test** — `constants_test` had a test asserting
`enum.toString()` returns the qualified name. That is Dart SDK
behaviour, not this repo's to verify, so it was removed.

## Verification
- `dcm analyze packages` -> no issues found.
- `dart analyze` clean across affected packages (lib + test); `flutter
analyze --fatal-warnings` clean.
- Tests: gotrue constants_test 41, realtime transformers_test +
socket_test 55, gotrue type unit tests pass. gotrue `test/src` count
went 232 -> 231 (only the removed enum test); the 24 failures are
pre-existing integration tests that need a local server, identical to
baseline.

## Note
Enums are rendered with `.name`, which drops the `EnumType.` prefix from
the affected `toString`/log output (e.g. `signedIn` instead of
`AuthChangeEvent.signedIn`). Nothing asserts on these strings.

10 of 12 new or added lines in 7 files covered. (83.33%)

4078 of 4788 relevant lines covered (85.17%)

3.49 hits per line