iotaledger / iota / 27890130340
67%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1107
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 67.402% (-0.003%) from 67.405%
27890130340

push

github

web-flow 
refactor(iota-types): remove unused SignableBytes trait (#11983)

# Description of change

The `SignableBytes` trait in `iota-types::crypto` is the BCS-decode
counterpart to `Signable`'s write/encode side, exposing
`from_signable_bytes(&[u8]) -> Result<Self>`. A search of the repo shows
it has **no production call sites** — `from_signable_bytes` was only
ever invoked from tests. The encode side (`Signable::write`) is used in
production (signing checkpoints, effects, transactions, …); the decode
side is not wired into any live code path.

This PR removes the dead trait and its only consumers:

- the `SignableBytes` trait definition,
- its blanket impl over `T: BcsSignable`,
- the manual `SignableBytes for MoveAuthenticator` impl,
- the now-orphaned `MoveAuthenticator::from_inner` helper (its sole
caller was the removed impl), and
- the test-only call sites in `move_authenticator.rs` and
`crypto_tests.rs`.

The `Signable` (write) machinery and the `bcs_signable_test` fixtures
(`Foo`/`Bar`) are still used elsewhere (e.g. `base_types_tests.rs`,
`messages_tests.rs`, and the verification-obligation tests) and are left
untouched. The remaining `MoveAuthenticator` `signable_bytes_*` tests,
which exercise the write-side format, are kept.

## Links to any relevant issues

N/A

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes

`cargo check -p iota-types --tests` is clean (no new warnings), and
`cargo nextest run -p iota-types --lib move_authenticator crypto` passes
(21 tests). The only removed tests are those that exercised the deleted
`from_signable_bytes` path.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

157991 of 234401 relevant lines covered (67.4%)

472472.28 hits per line

Coverage Regressions

Lines Coverage ∆ File
35
87.58
 0.0% crates/iota-types/src/move_authenticator.rs
27
79.74
 -0.12% crates/iota-types/src/crypto.rs
7
70.83
 -14.58% crates/iota-network-stack/src/anemo_ext.rs
5
91.52
 -0.33% crates/iota-protocol-config/src/lib.rs
4
74.96
 -0.58% crates/iota-network/src/randomness/mod.rs
4
82.45
 -0.79% crates/starfish/core/src/network/tonic_network.rs
2
82.28
 -0.06% crates/iota-core/src/authority.rs
2
90.71
 -0.24% crates/iota-network/src/state_sync/mod.rs
1
91.8
 -0.11% crates/iota-core/src/epoch/randomness.rs
1
95.65
 -4.35% crates/iota-keys/src/random_names.rs
1
89.03
 -0.14% crates/iota-network/src/discovery/mod.rs
1
99.63
 -0.09% crates/starfish/core/src/block_manager/mod.rs
1
96.37
 -0.13% crates/starfish/core/src/block_verifier.rs
1
94.93
 -0.04% crates/starfish/core/src/core.rs
1
83.45
 -0.24% crates/starfish/core/src/core_thread.rs
1
75.05
 -0.1% crates/test-cluster/src/lib.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 27890130340.1 1107
67.4
 GitHub Action Run
Source Files on build 27890130340