iotaledger / iota / 27856413163
67%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1107
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 67.405% (+0.02%) from 67.383%
27856413163

push

github

web-flow 
refactor(iota-types): remove unused SignableBytes trait (#11983)

# Description of change

The `SignableBytes` trait in `iota-types::crypto` is the BCS-decode
counterpart to `Signable`'s write/encode side, exposing
`from_signable_bytes(&[u8]) -> Result<Self>`. A search of the repo shows
it has **no production call sites** — `from_signable_bytes` was only
ever invoked from tests. The encode side (`Signable::write`) is used in
production (signing checkpoints, effects, transactions, …); the decode
side is not wired into any live code path.

This PR removes the dead trait and its only consumers:

- the `SignableBytes` trait definition,
- its blanket impl over `T: BcsSignable`,
- the manual `SignableBytes for MoveAuthenticator` impl,
- the now-orphaned `MoveAuthenticator::from_inner` helper (its sole
caller was the removed impl), and
- the test-only call sites in `move_authenticator.rs` and
`crypto_tests.rs`.

The `Signable` (write) machinery and the `bcs_signable_test` fixtures
(`Foo`/`Bar`) are still used elsewhere (e.g. `base_types_tests.rs`,
`messages_tests.rs`, and the verification-obligation tests) and are left
untouched. The remaining `MoveAuthenticator` `signable_bytes_*` tests,
which exercise the write-side format, are kept.

## Links to any relevant issues

N/A

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes

`cargo check -p iota-types --tests` is clean (no new warnings), and
`cargo nextest run -p iota-types --lib move_authenticator crypto` passes
(21 tests). The only removed tests are those that exercised the deleted
`from_signable_bytes` path.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

157998 of 234401 relevant lines covered (67.41%)

446691.22 hits per line

Coverage Regressions

Lines Coverage ∆ File
19
75.15
 1.28% crates/test-cluster/src/lib.rs
17
87.36
 -0.77% crates/iota-test-transaction-builder/src/lib.rs
15
84.65
 -1.65% crates/iota-transaction-builder/src/lib.rs
14
89.43
 -5.28% iota-execution/latest/iota-move-natives/src/authentication_context.rs
11
62.5
 -15.28% crates/iota-config/src/transaction_deny_config.rs
10
60.18
 0.21% crates/iota-json-rpc-types/src/iota_transaction.rs
8
56.64
 -1.12% crates/iota-json-rpc-types/src/iota_object.rs
7
71.79
 -1.99% crates/iota-transaction-builder/src/utils.rs
6
72.11
 -4.08% crates/iota-json-rpc-types/src/lib.rs
6
44.55
 -0.99% crates/iota-json-rpc-types/src/object_changes.rs
6
64.67
 -3.59% crates/iota-types/src/iota_system_state/mod.rs
4
68.2
 0.48% crates/iota-core/src/authority/authority_store.rs
4
53.24
 -1.37% crates/iota-sdk/src/apis/read.rs
4
63.25
 -2.41% crates/iota-stardust-types/src/block/output/nft.rs
4
89.14
 -0.99% crates/iota-types/src/base_types.rs
3
88.36
 -0.26% crates/iota-genesis-builder/src/lib.rs
3
82.35
 0.0% crates/iota-genesis-builder/src/stardust/types/output_header.rs
3
82.14
 0.0% crates/iota-genesis-builder/src/validator_info.rs
3
24.14
 -2.59% crates/iota-json-rpc-types/src/iota_checkpoint.rs
3
91.85
 2.8% crates/iota-protocol-config/src/lib.rs
3
0.0
 -6.38% crates/iota-stardust-types/src/block/protocol.rs
2
89.35
 -0.69% crates/iota-core/src/connection_monitor.rs
1
91.37
 0.13% crates/iota-core/src/execution_cache/writeback_cache.rs
1
89.16
 0.0% crates/iota-network/src/discovery/mod.rs
1
97.3
 -0.1% crates/starfish/core/src/cordial_knowledge.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 27856413163.1 1107
67.41
 GitHub Action Run
Source Files on build 27856413163