vallen-systems / vallenae / 27772662379

96%

master: 96%

push

github

fix: correct time-range to sample mapping in TraDatabase.read_continuous_wave

`read_continuous_wave` can return the wrong number of
samples - and can silently drop data - when reading by an exact time range,
especially when `time_start` falls just before or inside a hit.

Root causes:
- `_get_trai_range_from_time_range` derived its TRAI bounds from record
  start times only, so it skipped the record that straddles `time_start`
  and the record starting at `time_stop`. It now selects every record
  that overlaps the range (querying `view_tr_data`, whose `Time` is in
  seconds, so no timebase conversion or rounding is needed).
- `iread`'s empty-range guard compared `time_start` against the last
  record's *start* time, treating a window that starts inside the last
  record as "past the end" -> data loss. `_get_total_time_range` now
  returns the true data extent (end of the last sample) and the guard
  uses it.
- `read_continuous_wave` summed independently-rounded block/gap lengths,
  drifting by +/-1. It now preallocates `round(stop*fs) - round(start*fs)`
  samples and places each record by integer offset, using the record
  SampleRate (not the database TimeBase) and the channel's own extent for
  open bounds. The `_get_previous_trai` prepend workaround is removed.

An explicit window fully outside the data now returns zeros of the
requested length (consistent with the gap-fill contract) instead of an
empty array.

Add regression tests; restructure the read_continuous_wave tests around a
value-equals-time fixture with parametrized cases.

106 of 106 branches covered (100.0%)

Branch coverage included in aggregate %.

38 of 38 new or added lines in 1 file covered. (100.0%)

988 of 1031 relevant lines covered (95.83%)

0.96 hits per line