vallen-systems / vallenae / 27568331471

96%

push

github

fix: handle gaps in TRAI column when reading by time range (#49)

`read_continuous_wave`/`iread` with a time range crashed with
`TypeError: 'NoneType' object is not subscriptable` on tradb files
whose TRAI column is sparse (has gaps). The binary search over TRAI
probed arithmetic midpoints with `WHERE TRAI == <mid>`, which returns
no row when that TRAI doesn't exist.

Snap each probe to the nearest existing row in the search direction
instead, so a missing index is never queried. Since the result is only
used as a range bound (`TRAI >= start` / `TRAI <= stop`), it no longer
needs to be an existing index — any threshold in the gap selects the
same rows. This also lets the same-value linear bounding be dropped.

109 of 109 branches covered (100.0%)

Branch coverage included in aggregate %.

23 of 23 new or added lines in 1 file covered. (100.0%)

1000 of 1045 relevant lines covered (95.69%)

0.96 hits per line