supabase / supabase-flutter / 27769861530
85%

DEFAULT BRANCH: main
Ran
Jobs 8
Files 78
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.165% (+0.006%) from 85.159%
27769861530

push

github

web-flow 
chore(supabase_lints): enable six DCM rules to guard new code, ignoring their intentional existing hits (#1425)

Stacked on #1424.

## What

Enables six DCM rules that each had only one or two violations. After
inspection, every violation is a false positive or a deliberate pattern,
so the rules are enabled with targeted inline `// ignore:` directives
rather than code changes. This keeps new code covered by the rules while
documenting the known exceptions.

| Rule | Site | Why ignored |
|------|------|-------------|
| `avoid-unassigned-fields` | `supabase_stream_builder` `_streamFilter`
| Declared on the base class, assigned in the
`SupabaseStreamFilterBuilder` subclass. |
| `avoid-passing-self-as-argument` | `realtime_channel` rejoin | Re-auth
passes the socket's current token to its own `setAuth`, which requires
the argument. |
| `avoid-duplicate-constant-values` | `serializer` `kindUserBroadcast =
4` | Coincidentally equals `userBroadcastMetaLength = 4`; distinct
protocol values that must not change. |
| `avoid-unnecessary-type-assertions` | `postgrest_builder` `then` | The
`onError` arity checks are real runtime validation; DCM mis-models
function-type `is!` checks as always-true. |
| `match-getter-setter-field-names` | gotrue `snakeCase`, lifecycle_test
fake | A `@Deprecated` alias getter and a test fake's overridden getter.
|
| `function-always-returns-null` | `RealtimeClient.push`, test mock
handler | Public `push` has a vestigial `String?` return (changing to
`void` would be breaking); the other is a mock method-call handler. |

## Verification
- `dcm analyze packages` -> no issues found (including no
unused-ignores).
- `dart analyze` clean across affected packages (lib + test).
- `flutter analyze --fatal-warnings` clean on supabase_flutter.
- Tests: postgrest stack_trace_test (exercises `then` onError
validation) 5 pass, realtime socket_test 36 pass, supabase_flutter 49
pass.

## Note
These are comment-only changes (inline ignores); no runtim... (continued)

4076 of 4786 relevant lines covered (85.17%)

3.47 hits per line

Coverage Regressions

Lines Coverage ∆ File
22
88.92
 0.0% packages/realtime_client/lib/src/realtime_channel.dart
13
91.26
 0.09% packages/realtime_client/lib/src/realtime_client.dart
Jobs
ID Job ID Ran Files Coverage
1 realtime_client - 27769861530.1 11
88.15
 GitHub Action Run
2 supabase - 27769861530.2 15
82.1
 GitHub Action Run
3 storage_client - 27769861530.3 5
93.01
 GitHub Action Run
4 gotrue - 27769861530.4 26
83.51
 GitHub Action Run
5 functions_client - 27769861530.5 2
97.1
 GitHub Action Run
6 postgrest - 27769861530.6 9
83.76
 GitHub Action Run
7 yet_another_json_isolate - 27769861530.7 1
79.03
 GitHub Action Run
8 supabase_flutter - 27769861530.8 9
77.0
 GitHub Action Run
Source Files on build 27769861530