GrottoCenter / grottocenter-api / 27713535674

88%

Build Type

push

github

Committed by ClemRz

Commit Message

fix(search): address code review feedback on geo-export serializers

- Exclude geometry fields from GeoJSON properties and KML ExtendedData
- Omit altitude from KML coordinates when null instead of defaulting to 0
- Escape coordinate values through escapeXml in KML for consistency
- Extract shared xml-utils module (escapeXml, toStringValue) for KML/GPX
- Remove unused fieldMapping parameter from serializer signatures
- Simplify MAX_NB_ROW_EXPORT guard (first-page-only check)
- Extract validateColumns helper to reduce duplication in controller
- Add RFC 7946 note on non-standard FeatureCollection properties
- Add 'name' to KML GEOMETRY_FIELDS to prevent duplicate in ExtendedData
- Rename 'url' to 'grottocenterUrl' in GeoJSON/KML to avoid column alias collision
- Align CSV exit condition to use < BATCH_SIZE for consistency
- Update property and route tests to match corrected behavior

Coverage Stats

4356 of 5235 branches covered (83.21%)

Branch coverage included in aggregate %.

61 of 64 new or added lines in 5 files covered. (95.31%)

16 existing lines in 1 file now uncovered.

8312 of 9326 relevant lines covered (89.13%)

131.13 hits per line