GrottoCenter / grottocenter-api / 27829053887
88%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 457
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 87.059% (+0.06%) from 87.0%
27829053887

push

github

ClemRz 
feat(observations): address review round 3 feedback

- Trim substance before storing (normalizeSubstance helper)
- Use normalizeSubstance consistently in create, update, and EntityBuilder
- Restore FK constraint to NOT DEFERRABLE after migration ID reassignment
- Add comment about historical time series substance = NULL
- Add test: PATCH { substance: null } on non-substance-requiring QK
- Add doc note about geom exclusion in test view

4402 of 5279 branches covered (83.39%)

Branch coverage included in aggregate %.

8 of 9 new or added lines in 3 files covered. (88.89%)

15 existing lines in 4 files now uncovered.

8346 of 9364 relevant lines covered (89.13%)

135.46 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
90.0
 1.82% api/controllers/v1/sensor-configuration/update.js

Coverage Regressions

Lines Coverage ∆ File
8
83.33
 0.63% api/services/observation-import/EntityBuilder.js
4
90.0
 1.82% api/controllers/v1/sensor-configuration/update.js
2
93.81
 -3.09% api/services/RecentChangeService.js
1
97.61
 0.01% api/services/mapping/converters.js
Jobs
ID Job ID Ran Files Coverage
1 27829053887.1 457
87.06
 GitHub Action Run
Source Files on build 27829053887