Freegle / Iznik / 21586

71%

push

circleci

fix(spatial): centroid postcode geometry so 2M-row load doesn't error on non-point rows (#767)

The postcodes dataset loader called ST_X/ST_Y directly on
COALESCE(ourgeometry, geometry). A handful of type='Postcode' rows carry a
non-point ourgeometry (a LINESTRING/polygon override), and ST_X only accepts a
POINT, so the whole prod load aborted with:

  Error 3516 (22S01): POINT value is a geometry of unexpected type LINESTRING in st_x.

leaving the postcodes index empty (count 0, ready false) and breaking
Location::closestPostcode / apiv2 ClosestPostcode in production. CI passed
because its seeded test postcodes are all points.

Wrap the geometry in ST_Centroid first (a POINT is its own centroid;
LINESTRING/POLYGON collapse to a representative point), matching the existing
expression in compare.go. Verified against prod: 1,961,927 postcodes load and
KNN returns the correct nearest full postcode (WC2N 5DU for Charing Cross,
M2 4NG for central Manchester, both within ~90m).

Co-authored-by: root <root@localhost>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

10979 of 14580 branches covered (75.3%)

Branch coverage included in aggregate %.

118917 of 168850 relevant lines covered (70.43%)

36.24 hits per line