Freegle / Iznik / 21571

71%

Build Type

push

circleci

Committed by web-flow

Commit Message

spatial: nearest-neighbour lookups via spatial server; drop grid (#764)

* feat(spatial): nearest-neighbour lookups via spatial server; drop grid

Replace the per-table expanding-bounding-box MySQL nearest searches with the
iznik-spatial-go KNN index, and remove the vestigial locations_grids approach.

- spatial-go: new PostcodesDataset (point, ~2M rows, Extra=nil) + registered.
- Location::closestPostcode and IncomingMailService::findClosestPostcodeId
  (a duplicate) collapse to one SpatialQueryService->nearestIds('postcodes')
  call; expanding bbox removed.
- apiv2 location.ClosestPostcode -> spatial.KNN("postcodes"); closestPostcodeMySQL removed.
- Job::nearLocation -> spatial 'jobs' KNN; digest cpc floor 0.02 -> 0.10
  (matches the spatial index and the public jobs page).
- NewsfeedDigestService -> spatial 'newsfeed' KNN (nearest-N, re-filtered in
  MySQL); grow-radius getNearbyDistance/boxSql removed.
- Grid: DoogalService stops writing gridid; gridid dropped from Location
  PUBLIC_ATTS and UserLocationRemapService (no remaining consumers).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* feat(spatial): add admin /v1/{dataset}/upsert for test seeding + postcodes dataset test

The upsert endpoint inserts items by WKT (point or polygon, auto-detected) into
a live dataset index, decoupled from the MySQL rebuild — so integration tests can
seed a known geometry, exercise the real KNN path, then remove it. Smoke-tested:
upsert 2 postcode points -> KNN returns the nearest -> remove.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(spatial): point PHP config at SPATIAL_KNN_URL; integration-test closestPostcode

- config/freegle.php: spatial_server_url now reads SPATIAL_KNN_URL (the canonical
  finder var that batch already sets); SPATIAL_SERVER_URL is taken by the routing
  server, so relying on it resolved to localhost on batch and (with the fallback
  removed) would have broken closestPostcode/PostcodeRemapService in productio... (continued)

Coverage Stats

10980 of 14579 branches covered (75.31%)

Branch coverage included in aggregate %.

60 of 67 new or added lines in 7 files covered. (89.55%)

42 existing lines in 6 files now uncovered.

118917 of 168850 relevant lines covered (70.43%)

36.29 hits per line