wboayue / rust-ibapi / 27597853947

92%

Build Type

push

github

Committed by web-flow

Commit Message

Log benign data-farm connectivity notices at info, not warn (#678)

* Log benign data-farm connectivity notices at info, not warn

IB's message-codes reference classifies 2104/2106/2158 (data farm
connection OK) as System Notifications, distinct from the warning-band
codes (2100-2169) that report actual connectivity problems (e.g. 2103,
2105, 2157 - connection broken). log_unrouted_notice now routes these
three codes to info!, keeping warn! for everything else in the range.

* `time::format_description::parse` is deprecated, use `parse_borrowed` instead. cargo clippy now passed.

* review: prefix info log; derive + smoke-test the benign-code path

- log_unrouted_notice: prefix the benign arm "connectivity:" for symmetry
  with the "warning:"/"error:" siblings.
- test_is_benign_connectivity_notice: loop over BENIGN_CONNECTIVITY_CODES
  for the positive cases instead of re-hardcoding the literals.
- add test_log_unrouted_notice_traverses_all_severities: smoke-drive the
  info/warn/error branches (no log-capture harness available to assert level).

---------

Co-authored-by: Wil Boayue <wil.boayue@gmail.com>

Coverage Stats

6 of 6 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

18093 of 19720 relevant lines covered (91.75%)

28.79 hits per line