wboayue / rust-ibapi / 27596596748

92%

push

github

routing: unify data-advisory classification + end-to-end stream tests (#680)

* routing: unify data-advisory classification + end-to-end stream tests

Follow-up to #677. Two gaps from the review:

#2 Consistency: is_warning_error routed 10089/10167 as Notice (stream
stays open), but Notice::category()/is_error()/is_informational() still
reported them as errors — the two classifiers diverged. Promote the codes
to a shared messages::DATA_ADVISORY_CODES const (single source of truth,
re-exported alongside the other notice-code constants), add
Notice::is_data_advisory(), fold it into is_informational(), and add a
NoticeCategory::DataAdvisory variant. routing::is_warning_error now reads
the same const.

#1 Coverage: the original test only exercised the is_warning_error
predicate. Add end-to-end sync + async dispatcher tests asserting a 10167
frame is delivered as RoutedItem::Notice and the subscription stays open
for the follow-up data (the actual user-visible fix).

* simplify: DRY advisory-code test loops

Derive neighbor codes from each advisory code instead of hand-listing all
four, and drop redundant .iter() on the const-array loops. Test-only.

7 of 7 new or added lines in 2 files covered. (100.0%)

18089 of 19715 relevant lines covered (91.75%)

29.42 hits per line