wboayue / rust-ibapi / 27594529797

92%

push

github

fix: TickSubscription carries SubscriptionItem envelope (#675) (#679)

Historical-tick TickSubscription<T> (sync + async) missed the #504
SubscriptionItem migration. It kept the old error-storing pattern — a
private error field with no accessor and next() -> Option<T> — so a
mid-stream decode/transport error was indistinguishable from end-of-data.
The async side was worse: it discarded the error entirely (dead set_error).

Both now carry the same Option<Result<SubscriptionItem<T>, Error>> shape as
Subscription<T>:

- sync: next/try_next/next_timeout return the envelope; added next_data and
  iter_data/try_iter_data/timeout_iter_data; dropped error field +
  set_error/clear_error.
- async: implements futures::Stream (full parity); filter_data()/next().await
  come via the existing ext traits; dropped the error field.
- shared classify(RoutedItem) -> TickAction in common/tick.rs; both drivers
  switch from into_legacy() (drops notices, swallows errors) to next_routed().
- removes the latent T::decode().unwrap() panic — decode errors route to Err.
- distinct done vs stream_ended flags.
- gates now-test-only InternalSubscription::try_next/next_timeout with
  #[cfg(test)], matching the async next_routed convention.

Tests: classify unit tests + sync/async regression guards (error surfaces via
Err, notice passthrough, iter_data/filter_data filters notice keeps Err).
Docs: migration §1 + §25, 7 examples, 6 builder doc-examples.

Breaking change (v3, sync + async features).

67 of 73 new or added lines in 3 files covered. (91.78%)

18083 of 19710 relevant lines covered (91.75%)

28.52 hits per line