rero / rero-ils / 27526538123

91%

staging: 91%

Build Type

push

github

Committed by Garfield-fr

Commit Message

refactor: normalize monetary amounts to two decimal places

Floating-point drift (e.g. 145.000000089) in financial fields
caused silent precision errors. All monetary amounts are now
normalized to exactly two decimal places on write using
Decimal arithmetic.

* Add NormalizeAmountExtension to extensions.py: on pre_create/pre_commit,
  validates that each monetary value is within 1e-9 of a two-decimal number
  (raises ValidationError for values like 0.545 or 2.23333, preserving the
  behavior of the former DecimalAmountExtension) and silently normalizes
  float-drift residuals (e.g. 145.000000089) to exactly two decimal places
* Register NormalizeAmountExtension in AcqAccount,
  AcqOrderLine, AcqReceiptLine, AcqReceipt, PatronTransaction,
  PatronTransactionEvent, CircPolicy, PatronType and Item
* Fix arithmetic in acq_accounts (remaining_balance,
  get_exceedance, transfer_fund), acq_receipt_lines
  (total_amount) and acq_receipts (total_amount) to return
  values rounded to 2dp
* Guard total_amount against None in update_parent_patron_transaction
  to avoid TypeError when a patron transaction has no total_amount yet
* Add Alembic migration b3a1f2c9d0e7: normalizes all existing
  monetary fields in DB to two decimal places (idempotent
  upgrade and downgrade)

Co-Authored-by: Peter Weber <peter.weber@rero.ch>

Coverage Stats

64 of 64 new or added lines in 10 files covered. (100.0%)

25 existing lines in 2 files now uncovered.

24180 of 26495 relevant lines covered (91.26%)

0.91 hits per line