IJHack / QtPass / 27505241535

58%

push

github

refactor: add QtPassSettings::load/save AppSettings facade (#1511) (#1539)

Stage 3 of #1511. Adds the single load()/save() pair the issue envisions as
QtPassSettings' eventual public surface:

- QtPassSettings::load() -> AppSettings (via SettingsSerializer on the
  singleton store)
- QtPassSettings::save(const AppSettings&) -> writes via SettingsSerializer
  and invalidates the cached Pass backend, folding in the old setUsePass()
  side effect.

Migrate ConfigDialog (the stage-2 consumer) onto the facade: applySettings
now takes QtPassSettings::load(), and on_accepted is QtPassSettings::save(
readSettings()) — dropping its direct SettingsSerializer dependency and the
explicit setUsePass() backend-reset call.

Reader migration stays incremental on purpose: settings are runtime-mutable
(ConfigDialog writes them), so callers must read current values rather than
cache a struct; load() gives them a clean per-use snapshot without the 132
individual getters. Wrapper deletion (stage 4) follows once readers move
across.

tst_settings gains a facade round-trip case (117 pass). configdialog (16) and
full make check green; doxygen and reuse clean.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

7 of 9 new or added lines in 2 files covered. (77.78%)

3986 of 6929 relevant lines covered (57.53%)

36.23 hits per line