IJHack / QtPass / 27502986312

57%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: move tree-root mapping into StoreModel::rootIndexFor (#1512) (#1537)

* refactor: move tree-root mapping into StoreModel::rootIndexFor (#1512)

Final slice of the MainWindow decomposition (#1512), the tree-model
boundary fix. The 'mapFromSource(model.setRootPath(path))' incantation to
point the tree view at a directory was repeated at six sites in MainWindow,
reaching through the proxy into the wrapped QFileSystemModel.

Add StoreModel::rootIndexFor(path) which performs that mapping internally
(returning an invalid index when no source model is set) and replace the six
call sites. The one-time setup in the constructor keeps its inline form
because it reuses the source root index for fetchMore before the proxy is
wired.

Adds two tst_storemodel cases (null source model, delegation equivalence).
make check green (model 38, mainwindow 14); doxygen and reuse clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix: normalize path in rootIndexFor + QVERIFY2 in test (#1512)

- StoreModel::rootIndexFor now QDir::cleanPath()-normalizes the path before
  setRootPath(), per the cross-platform path-handling guideline.
- tst_storemodel: use QVERIFY2 with a message for the tempDir precondition
  and match the helper's cleanPath() contract in the manual-mapping compare.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Coverage Stats

3 of 12 new or added lines in 2 files covered. (25.0%)

1 existing line in 1 file now uncovered.

3980 of 6925 relevant lines covered (57.47%)

36.21 hits per line