kobotoolbox / kpi / 27291118493

82%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

feat(auditLogs): filter list endpoints by lookback DEV-1461 (#7137)


### 📣 Summary
Restrict API endpoints for audit logs to only look back the number of
days allowed by the user's subscription.


### 📖 Description
Restricts the following endpoints:
- audit logs
- access logs (personal and global)
- project history logs (project-specific and global)
If stripe is not enabled, the number of days allowed is set based on the
log retention settings of the server.

### Notes
One small inheritance change, AccessLogViewSet now inherits from
AllAccessLogViewSet to avoid having to write the same queryset twice.
The unit testing around the access log view set is quite comprehensive
so there is not much fear of regression, and it was also tested locally.


### 👀 Preview steps

1. ℹ️ have an admin account and a project
2. ℹ️ Ensure you have access logs and project history logs that are at
least 3 days old
3. In Django admin, update the default plan (or whatever plan you admin
user is on) to have `"log_lookback_days_limit": "2"` in the metadata
4. 🟢 For each of the following endpoints, ensure there are no logs older
than 2 days old:
  * /api/v2/audit-logs/
  * /api/v2/access-logs/me/
  * /api/v2/access-logs/
  * /api/v2/project-history-logs/
  * /api/v2/assets/<asset_uid>/history/

Coverage Stats

9027 of 12260 branches covered (73.63%)

8 of 23 new or added lines in 1 file covered. (34.78%)

442 existing lines in 20 files now uncovered.

29627 of 36318 relevant lines covered (81.58%)

5.56 hits per line