akvo / akvo-mis / #661

88%

push

coveralls-python

#229: Form Builder Backend CRUD API (FB-002 / FB-002A) (#230)

* [#229] Rename QuestionTypes.photo to image across the backend

- Rename QuestionTypes.photo = 8 to QuestionTypes.image = 8 in constants.py
- Update all usages: v1_data models/serializers/views/functions/tests,
  v1_jobs, v1_mobile tests, seeder_answer_processor, example-1.json
- Add migration 0007 to update the DB FieldStr for the renamed constant
- Update generate_config.py import formatting (flake8)

No DB integer value change — image = 8 matches the prior photo = 8.
akvo-react-form-editor emits "image"; this rename aligns the backend.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* [#229] Implement form builder backend CRUD API (FB-002)

- Add FormStatus (draft=1, published=2) to v1_forms/constants.py
- Add status, published_at, previous_version FK fields to Forms model
- Migration 0008: sets status=PUBLISHED (2) for all existing rows
- Add FormDetailSerializer, FormDetailQuestionSerializer,
  FormDetailQuestionGroupSerializer, FormVersionSerializer;
  extend ListFormSerializer with status field
- New functions.py: save_form, version_on_edit, duplicate_form,
  validate_form_payload (all atomic where write)
- New CRUD views with @extend_schema(tags=["Form Builder"]):
  GET/POST /api/v1/forms, GET/PUT/DELETE /api/v1/forms/{id},
  POST /api/v1/forms/{id}/publish, POST /api/v1/forms/{id}/duplicate,
  GET /api/v1/forms/{id}/versions
- PUT on PUBLISHED form creates new draft with version+1 (returns 201);
  PUT on DRAFT replaces in-place (returns 200)
- DELETE requires superuser; blocked with 409 if submissions exist
- Add IsFormBuilder(BasePermission) to custom_permissions.py using
  FeatureAccessTypes.form_builder / FeatureTypes.form_builder
- Add form_builder feature type to v1_profile constants and migrations
- Seed form_builder feature access in default_roles_seeder
- Add tests_form_crud.py with 21 tests (all ... (continued)

5355 of 6205 branches covered (86.3%)

Branch coverage included in aggregate %.

10223 of 11376 relevant lines covered (89.86%)

0.9 hits per line