bitcoindevkit / bdk / 27235407705

79%

master: 78%

push

github

Merge bitcoindevkit/bdk#2222: fix(core,chain,electrum,esplora): backport #2182

<a class=hub.com/bitcoindevkit/bdk/commit/6e33fe3fe1a5f52067cf3f9831e7434684fd177c">6e33fe3fe<a href="https://github.com/bitcoindevkit/bdk/commit/5f34c785ff6b95c139241866275ac13b198e715e"> fix: adjust #2182 backport source/tests for 1.63 MSRV support (thunderbiscuit)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/b2dbd43627bf29508e81659a6d390b14400d0773">b2dbd4362</a><a href="https://github.com/bitcoindevkit/bdk/commit/5f34c785ff6b95c139241866275ac13b198e715e"> build: pin crates for 1.63 MSRV (thunderbiscuit)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/0c46840eb8cb9add8f65911d00a40eb6b910f814">0c46840eb</a> fix: full_scan covers revealed range before applying stop_gap (backport PR#2182) (Noah Joeris)

Pull request description:

  This is a backport of the fix brought into #2182, allowing it to be released in the bdk_chain 0.23.x series so that users of bdk_wallet 3.0 can benefit from the bug fix.

  See PR #2182 and issue #2057 for full discussion on the bug and the fix.

  ### Changelog notice

  ```md
  ## Fixed
  - full_scan now always scans the full revealed range before applying stop_gap past last_revealed
  ```

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  oleonardolima:
    ACK 6e33fe3fe1a5f52067cf3f9831e7434684fd177c

Tree-SHA512: 59e810ee6a4f874d713db587b74769ff612

396 of 542 branches covered (73.06%)

Branch coverage included in aggregate %.

31 of 36 new or added lines in 5 files covered. (86.11%)

4426 of 5555 relevant lines covered (79.68%)

2128.33 hits per line