bitcoindevkit / bdk / 27651473836

79%

master: 78%

push

github

Merge bitcoindevkit/bdk#2228: fix(electrum): backport PR#2188

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/f4775531f2a4a001ca325e2a89ba1b84512a99e5">f4775531f<a href="https://github.com/bitcoindevkit/bdk/commit/fff8f8ad1a810198100c1f1e61bff6e558e71dfd"> fix(electrum): verify txid of server-returned transactions (Elias Rohrer)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/f8a4705db94660ea34f3d281892aa76b01f19e93">f8a4705db</a> fix(ci): pin `zeroize` to `1.8.2` (Leonardo Lima)

Pull request description:

  ### Description

  It's a backport for the the `bdk_electrum` fix introduced by https://github.com/bitcoindevkit/bdk/pull/2188. If you're interested in the original fix, check the original PR for discussion/rationale.

  ### Changelog notice

  ```
  ### Fixed
  - Add a verification check that tx.compute_txid() == txid after fetching from the server, returning an error on mismatch
  ```

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

ACKs for top commit:
  luisschwab:
    ACK f4775531f2a4a001ca325e2a89ba1b84512a99e5
  nymius:
    ACK f4775531f2a4a001ca325e2a89ba1b84512a99e5

Tree-SHA512: 83b02ecff3cd9f82b5977126a3f4c10c705

397 of 544 branches covered (72.98%)

Branch coverage included in aggregate %.

3 of 6 new or added lines in 1 file covered. (50.0%)

4429 of 5561 relevant lines covered (79.64%)

2076.62 hits per line