bitcoindevkit / bdk / 25599869850

79%

master: 78%

push

github

Merge bitcoindevkit/bdk#2198: fix(bitcoind_rpc): backport PR#2167

<a class=hub.com/bitcoindevkit/bdk/commit/b5af3c78d08538645783dac15a84afbaffa4eabf">b5af3c78d fix(bitcoind_rpc): emit invalidated heights when start_height is above agreement point (志宇)

Pull request description:

  ### Description

  It's a backport for the the `bdk_bitcoind_rpc` fix introduced by #2167. If you're interested in the original fix, check the original PR for discussion/rationale.

  ### Notes to the reviewers

  The introduced tests needs a review, as I had to update it use the older Emitter and TestEnv APIs.

  ### Changelog notice

  ```
  ### Fixed:
  - `Emitter` producing un-connectable checkpoints when `start_height` is above the agreement point after a reorg.
  ```

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### Bugfixes:

  * [x] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  evanlinjin:
    ACK b5af3c78d08538645783dac15a84afbaffa4eabf

Tree-SHA512: d9166fd37b3cc465fc54e823ef5fb8911a9

390 of 536 branches covered (72.76%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

4406 of 5532 relevant lines covered (79.65%)

2170.28 hits per line