lsm / neokai / 27182037313

82%

push

github

ACP PR2: Client + query adapter + message translator (#2077)

* feat: ACP client + query adapter + message translator

Implements PR 2 of the ACP provider support chain:

- acp-client.ts: protocol client wrapping AcpTransport with lifecycle
  (initialize, authenticate, createSession, sendPrompt, cancel, close)
  and server-to-client request delegation (fs, terminal, permissions).

- acp-message-translator.ts: pure translation functions that accumulate
  streaming chunks into complete SDKAssistantMessage, plus tool_use and
  tool_progress translation and result message generation.

- acp-query-adapter.ts: Query-contract adapter implementing
  AsyncIterable<SDKMessage> with interrupt(), close(), sessionId getter,
  and setMcpServers() no-op.

Tests:
- Unit tests for each notification type → correct SDKMessage shape
- Unit tests for chunk accumulation and boundary flushing
- Integration test with mock transport exercising full lifecycle

Dead code until PR 4 wires it up behind provider === 'acp'.

* fix(acp): address review comments — stop reason, errors, capabilities, tool output

- Propagate ACP prompt stop reason from sendPrompt response through to
  translateResult() instead of hard-coding end_turn.
- Throw prompt errors after draining queued updates in sendPrompt.
- Return SDK-compatible McpSetServersResult shape from setMcpServers().
- Dispatch fs/read_text_file and fs/write_text_file wire methods.
- Build clientCapabilities in initialize() from actually-provided callbacks.
- Reject unsupported ACP protocol versions during initialize().
- Preserve ACP tool output by emitting synthetic user messages with
  tool_use_result on tool_call_update notifications that carry content
  or rawOutput.

10124 of 14808 branches covered (68.37%)

Branch coverage included in aggregate %.

86839 of 103125 relevant lines covered (84.21%)

291.27 hits per line