MushroomObserver / mushroom-observer / 27105860662

98%

push

github

Description#put_together_name: fix source_type ||= local-shadow bug (#4447)

`source_type ||= :public` parses as `source_type = source_type || :public`.
On the LHS, Ruby treats `source_type` as a new local variable, which
shadows the AR `source_type` reader for the rest of the method. So
the RHS read returned `nil` (the freshly-declared local), the `||`
always picked `:public`, and every description rendered with the
public title format — regardless of its actual `source_type`.

Assign to a differently-named local (`type`) so the RHS stays a method
call on the record.

Also add the previously-missing partial-title translations for
project / source / foreign source types. The bug was masking them: pre-
fix, those source_types collapsed to `description_part_title_public`,
so the un-`_with_text` variants for the other three never had to exist.
With the fix in place, a description that is e.g. `source_type: :project`
with no `source_name` now requests `description_part_title_project`,
which needs to resolve.

Tests:
- existing `test_user_sourced_description_with_unknown_user` updated:
  pre-fix it asserted the buggy "Public Description of …" output;
  now asserts the correct user-source format (`?'s …`).
- new tests cover each source_type's partial / full title shape, plus
  a nil-source_type fallback-to-public assertion.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2 of 2 new or added lines in 1 file covered. (100.0%)

44139 of 45279 relevant lines covered (97.48%)

763.16 hits per line