MushroomObserver / mushroom-observer / 27105701459

98%

Build Type

push

github

Committed by web-flow

Commit Message

Phlexify rest of observations/namings + dismantle ObservationsHelper (#4458)

* Phlexify namings/{index,votes/index,votes/_table,_update_matrix_box}; header d-flex fix

Five conversions in the obs-show/namings domain plus a one-line
visual fix on the namings panel header:

- `Views::Controllers::Observations::Show::Namings::Header`:
  `COLUMN_BEHAVIOR` constant gains `d-flex` so the
  `flex-column justify-content-end` actually bottom-aligns the
  column-label text. Without `d-flex`, `.col` is not a flex
  container and the layout props are no-ops — the labels hover
  at the top of the row whenever "Community Vote" wraps to two
  lines on `sm`.

- `Views::Controllers::Observations::Namings::Index` replaces
  `namings/index.erb` — derives the consensus from the
  observation internally so the controller doesn't carry an
  `@consensus` ivar whose only job is to pass through.

- `Views::Controllers::Observations::Namings::Votes::Table`
  replaces `votes/_table.erb`. Renders the per-naming vote
  breakdown. Includes a NOTE explaining why
  `Components::Table` isn't used (mixed-shape rows + custom
  `table-naming-votes` styling). `String#%` is preferred over
  `format` throughout because `format` resolves to Phlex's
  `<format>` HTML element method inside a view scope.

- `Views::Controllers::Observations::Namings::Votes::Index`
  replaces `votes/index.erb`. Takes `naming:` only — Table
  derives consensus when not passed.

- `Views::Controllers::Observations::Namings::Votes::Modal`
  wraps the Table in `Components::Modal` for the turbo_stream
  modal response. Needs to live as a Phlex view (not inline at
  the controller) because `ActionController#render` treats a
  trailing block as a layout block rather than passing it to
  Phlex slot setters.

- The `_update_matrix_box.erb` turbo_stream partial (7
  turbo_stream actions: title swaps + modal dismissals + identify
  strip removal) is inlined as `render_update_matrix_box_streams`
  in `NamingsController` a... (continued)

Coverage Stats

287 of 289 new or added lines in 16 files covered. (99.31%)

2 existing lines in 1 file now uncovered.

44139 of 45279 relevant lines covered (97.48%)

765.35 hits per line