kobotoolbox / kpi / 26953616674

82%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

feat(asset): allow owners to delete empty assets DEV-1988 (#7090)

### 📣 Summary
Allow users to delete assets they have created if there are no
submissions.


### 📖 Description
Extends permission to delete an asset to a user if:
1. They created the asset
2. They have the manage_asset permission
3. The asset has no submissions


### 💭 Notes
Both single delete and bulk delete go through the bulk serializer, so
the change had to be made there in addition to the permissions check for
the single DELETE.
Adds the ability to pass a prefetched list of ObjectPermissions to pass
to `has_perm` to avoid multiple round trips to the DB for each asset.


### 👀 Preview steps

1. ℹ️ have an account and a project
2. Delete all submissions from the project
4. Add the account to an MMO with a different owner so the project is
transferred
5. From a terminal, DELETE to `api/v2/assets/<project_uid>` as the
account user (not the organization owner)
7. 🔴 [on main] 403
8. 🟢 [on PR] the asset is deleted
9. Create another asset and make sure it has 0 submissions
10. From a terminal, POST to `/api/v2/assets/bulk` with
```
{
"payload": {
     "asset_uids": ["<asset uid>"],
     "action": "delete"
}
}
```
7. 🔴 [on main] 403
8. 🟢 [on PR] the asset is deleted

Coverage Stats

9016 of 12244 branches covered (73.64%)

11 of 40 new or added lines in 2 files covered. (27.5%)

1 existing line in 1 file now uncovered.

29561 of 36248 relevant lines covered (81.55%)

5.56 hits per line