kobotoolbox / kpi / 26946674527

82%

master: 76%

push

github

fix(formMedia): improve multiple pending uploads handling DEV-1528 (#7095)

### 📣 Summary

Form Media now keeps the loading indicator visible until all dropped
files finish uploading, reducing confusing false-failure moments during
multi-file uploads.

### 📖 Description

This PR continues the Form Media modernization and fixes the key UX bug
from DEV-1528.

Previously, when users dropped multiple files, the loading spinner could
disappear after early files finished, even while large files were still
uploading. That made it look like upload had stopped, and users could
retry too early and hit misleading duplicate-file errors.

Now the spinner remains visible until every in-flight file upload
settles.
The PR also includes stronger story coverage for the multi-file case and
a small cleanup pass to make behavior and tests more reliable.

### 💭 Notes

Changes here:
- Form Media component:
- Added upload pending tracking based on in-flight upload count so
multi-file spinner behavior is accurate.
- Extracted pending upload tracking into a local reusable hook in the
same feature folder.
- Guarded link behavior for URL-based entries by omitting download
attribute for redirect-style items.
- Added handling for file-read failure edge case so pending state cannot
get stuck.
- Storybook and mocks:
- Added dedicated multi-file spinner story with staggered completion
timing.
- Improved assertions to target media rows/actions instead of generic
link counts.

Tiny joy nugget for reviewers (from AI):
- Spinner now does cardio all the way to the finish line instead of
clocking out after the first lap.

### 👀 Preview steps

1. Sign in and open any editable project.
2. Go to Project → Settings → Media.
3. Drag and drop at least two files, including one noticeably larger
file.
4. Confirm the uploading indicator appears immediately.
5. Wait until the small file appears in Attached files.
6. Confirm the uploading indicator is still visible while the larger
file is still proc... (continued)

8989 of 12216 branches covered (73.58%)

29532 of 36218 relevant lines covered (81.54%)

5.56 hits per line