agama-project / agama / 26952390565

81%

master: 83%

Pull #3584

github

fix(deps): add @patternfly/react-styles as an explicit dependency

Introduced in #3581, @patternfly/react-code-editor declares
@patternfly/react-styles with a loose `^6.4.0` range (published from
`workspace:^` in the PF monorepo). npm resolves that to 6.5.1 (latest
satisfying):

  @patternfly/react-code-editor@6.4.1
  └── @patternfly/react-styles@^6.4.0  →  resolved to 6.5.1

https://github.com/patternfly/patternfly-react/blob/189eb789f/packages/react-code-editor/package.json#L36

Other PF packages (e.g. react-core) also pull react-styles, but at a
different version. npm cannot flatten two different versions of the same
package to the root node_modules, so 6.5.1 ends up nested and direct
imports break at build/runtime:

  import textStyles from "@patternfly/react-styles/css/utilities/Text/text";
  import spacingStyles from "@patternfly/react-styles/css/utilities/Spacing/spacing";

PR #3581 already froze all other PatternFly deps to 6.4.x to avoid a
known layout regression in 6.5.1. Adding react-styles@6.4.0 explicitly
completes that freeze, collapses all transitive resolutions to the same
version, and guarantees a stable root-level path.

4401 of 6437 branches covered (68.37%)

Branch coverage included in aggregate %.

23912 of 28309 relevant lines covered (84.47%)

98.32 hits per line