agama-project / agama / 26945170747

83%

push

github

feat(web): better UI for dealing with installation settings (#3581)

## Problem

The web UI offered a direct download link for the current Agama
configuration, with no context about what the file contains or what it
is meant for. Users unfamiliar with Agama's configuration model would
have no way of knowing what they were downloading nor how the file could
be used later (e.g. for unattended installation via the CLI).

## Solution

Replaced the direct download link with a `ConfigDialog` component that
shows the configuration content before downloading it:

- The dialog title is **"Installation settings"**, which better reflects
that it shows the settings chosen for the installation. This aligns with
the terminology used in the CLI documentation (`agama config show`
displays the current *settings*).
- Displaying the content gives users a chance to understand what they
are about to download and decide whether it is what they need.
- The downloaded filename now includes a timestamp (e.g.
`agama-config-2024-01-15T10-30-00-000Z.json`) generated when the dialog
is opened, making it easier to identify files when downloading multiple
times during the same session.
- Introduced a shared `isoTimestamp` utility used consistently across
the codebase wherever a filesystem-safe timestamp is needed.


> [!WARNING]
>
> This PR _freeze_ some dependencies to avoid `npm install` to update
them since these needs some time arragments to deal with _breaking
changes_ . Namely, all PatternFly deps that breaks some visual
adjustments and ReactRouter that comes with [better typing for
`generagePath`](https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v7142)
that makes TS complains
(https://github.com/agama-project/agama/actions/runs/26893635603/job/79333824164)
> 
> > check-types
> > tsc --skipLibCheck
> > 
> > Error: src/components/storage/FilesystemMenu.test.tsx(83,83): error
TS2322: Type 'number' is not assignable to type 'string'.
> > ...



## Testing

- Adde... (continued)

4401 of 6437 branches covered (68.37%)

Branch coverage included in aggregate %.

28 of 29 new or added lines in 3 files covered. (96.55%)

23912 of 28309 relevant lines covered (84.47%)

98.32 hits per line