iotaledger / iota-rust-sdk / 26925346672
36%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 179
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 40.185% (+0.06%) from 40.126%
26925346672

push

github

web-flow 
feat!: `MultisigAggregatedSignature` changes (#1137)

* feat: MultisigAggregatedSignature changes

* add std feature to base64ct

* nits

* use into

* more clean up

* FFI new/insecure_new

* remove infallible

* remove infallible

* fix serde gating

* remove Move TODO

* hash gate

* custom proptest for multisigs

* fix bindings

* fix swift

* derive_more::Deref dor Digest

* remove TODO

* add `MultisigAggregatedSignature::new` to FFI

* improve docs

* fmt

* call is_valid in new

* panic message

* remove TODO

* remove TODO

* reorder

* add one line comment

* remove useless assert

* split FFI PublicKey from Multisig

* Update crates/iota-sdk-types/src/crypto/multisig.rs

Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>

* remove unwrap

* adapt public key doc comment

* rename signing_digest

* add bitmap count check to is_valid

* adapt proptest to new validation rule

* is_valid -> validate

* extract to_bytes/from_bytes from to_base64/from_base64

* nits

* remove TODO

* nits

* SignaturesOutOfOrder

* remove signature from NoPublicKeyForSignature

* don't swallow error

* lint

* expose MultisigError

* add SimpleSignature ctors

* review comments

* switch to sdk OnceLock

* refactor using split_first

* Update crates/iota-sdk-crypto/src/multisig.rs

Co-authored-by: Vlad Semenov <semenov.vlad.by@gmail.com>

* another use of split_first

* simple conversion

* sort derives

* use tail everywhere

* remove validation + update comment

* fix flag comments

* add checked_add

* remove insecure_new from FFI

* revert to checking sigs and committee

* simplify BCS comment

* add validation back

* remove TODO

* add comment about flag gap

* remove zklogin from PublicKey

* fix passkey flag

* remove zklogin from MultisigMemberSignature

* move PublicKey serde to public key module

* remove to_from bytes

* fine grained errors for comittee validation

* add tests

* fix test

* fix to_base64

* fix tests

* address so... (continued)

387 of 633 new or added lines in 9 files covered. (61.14%)

265 existing lines in 8 files now uncovered.

9186 of 22859 relevant lines covered (40.19%)

9142.41 hits per line

Uncovered Changes

Lines Coverage ∆ File
72
82.57
 -4.1% crates/iota-sdk-types/src/crypto/multisig.rs
68
0.0
 0.0% crates/iota-sdk-crypto/src/multisig.rs
48
52.94
 crates/iota-sdk-types/src/crypto/public_key.rs
34
71.15
 -6.0% crates/iota-sdk-types/src/crypto/signature.rs
14
39.32
 -1.8% crates/iota-sdk-types/src/hash.rs
7
72.0
 -9.4% crates/iota-sdk-crypto/src/passkey.rs
3
85.06
 -0.56% crates/iota-sdk-types/src/crypto/passkey.rs

Coverage Regressions

Lines Coverage ∆ File
126
68.09
 0.25% crates/iota-sdk-transaction-builder/src/builder/mod.rs
81
0.0
 -28.09% crates/iota-sdk-transaction-builder/src/builder/client_methods.rs
44
83.09
 -0.31% crates/iota-sdk-graphql-client/src/api/transactions.rs
8
54.15
 13.02% crates/iota-sdk-types/src/move_core/struct_tag.rs
2
71.15
 -6.0% crates/iota-sdk-types/src/crypto/signature.rs
2
39.32
 -1.8% crates/iota-sdk-types/src/hash.rs
1
0.0
 0.0% crates/iota-sdk-crypto/src/multisig.rs
1
72.0
 -9.4% crates/iota-sdk-crypto/src/passkey.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest - 26925346672.1 179
40.19
 GitHub Action Run
Source Files on build 26925346672