iotaledger / iota-rust-sdk / 26859154640

36%

Build Type

push

github

Committed by web-flow

Commit Message

fix(txn-builder): paginate auto gas-coin selection (#1162)

* fix(txn-builder): cap auto gas-coin selection to bound request size

Auto gas selection pinned every gas coin the sender owned, which on a
shared development address blew past the GraphQL server's 5000-byte
`query part` cap. Sort candidates largest-first, stop once the
configured budget is covered, and apply a hard cap of 16 inputs as
defense in depth.

Fixes #1160

* refactor(txn-builder): paginate gas-coin fetch for auto selection

Replace the single-page-and-cap strategy with a paginated top-K
selection: page through gas coins via a new ClientMethods::gas_coins_page
hook, keep the running top by balance, and stop fetching as soon as the
candidates cover the requested budget. Bump the hard ceiling to 256 to
match the protocol's max-gas-payment-objects limit.

The previous fix kept the request small but at the cost of a very low
cap (16); pagination plus budget-aware early-stop lets us bound request
size by what's actually needed rather than a blanket limit.

Adds an integration test that funds an address with 2048 coins (the
protocol's per-tx object-creation cap, reached via four `split_coins`
commands at the 512-argument-per-command ceiling) and verifies auto
gas-selection still succeeds.

* chore(txn-builder): trim stale narration from auto-gas test

* test(txn-builder): assert auto gas selection paginates

Extend the many-coins integration test to drain every large coin owned
by the sender after the funding phase, then route the exercise tx
through a counting wrapper client and assert at least two pages of
gas-coin lookups were performed.

Also cap the no-budget auto-selection loop at MAX_AUTO_GAS_PAYMENT_OBJECTS
so it doesn't walk every page of a high-cardinality wallet.

* chore: restore trailing whitespace stripped by stable rustfmt

Stable cargo fmt doesn't honor `normalize_comments = true`, so a prior
local format incorrectly stripped a trailing space inside an ABNF doc
block; nig... (continued)

Coverage Stats

166 of 193 new or added lines in 3 files covered. (86.01%)

15 existing lines in 6 files now uncovered.

9103 of 22686 relevant lines covered (40.13%)

9774.01 hits per line