iotaledger / iota-rust-sdk / 26990494904

36%

Build Type

push

github

Committed by web-flow

Commit Message

feat!: `MultisigAggregatedSignature` changes (#1137)

* feat: MultisigAggregatedSignature changes

* add std feature to base64ct

* nits

* use into

* more clean up

* FFI new/insecure_new

* remove infallible

* remove infallible

* fix serde gating

* remove Move TODO

* hash gate

* custom proptest for multisigs

* fix bindings

* fix swift

* derive_more::Deref dor Digest

* remove TODO

* add `MultisigAggregatedSignature::new` to FFI

* improve docs

* fmt

* call is_valid in new

* panic message

* remove TODO

* remove TODO

* reorder

* add one line comment

* remove useless assert

* split FFI PublicKey from Multisig

* Update crates/iota-sdk-types/src/crypto/multisig.rs

Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>

* remove unwrap

* adapt public key doc comment

* rename signing_digest

* add bitmap count check to is_valid

* adapt proptest to new validation rule

* is_valid -> validate

* extract to_bytes/from_bytes from to_base64/from_base64

* nits

* remove TODO

* nits

* SignaturesOutOfOrder

* remove signature from NoPublicKeyForSignature

* don't swallow error

* lint

* expose MultisigError

* add SimpleSignature ctors

* review comments

* switch to sdk OnceLock

* refactor using split_first

* Update crates/iota-sdk-crypto/src/multisig.rs

Co-authored-by: Vlad Semenov <semenov.vlad.by@gmail.com>

* another use of split_first

* simple conversion

* sort derives

* use tail everywhere

* remove validation + update comment

* fix flag comments

* add checked_add

* remove insecure_new from FFI

* revert to checking sigs and committee

* simplify BCS comment

* add validation back

* remove TODO

* add comment about flag gap

* remove zklogin from PublicKey

* fix passkey flag

* remove zklogin from MultisigMemberSignature

* move PublicKey serde to public key module

* remove to_from bytes

* fine grained errors for comittee validation

* add tests

* fix test

* fix to_base64

* fix tests

* address so... (continued)

Coverage Stats

385 of 633 new or added lines in 9 files covered. (60.82%)

255 existing lines in 9 files now uncovered.

9187 of 22859 relevant lines covered (40.19%)

9465.87 hits per line