MushroomObserver / mushroom-observer / 26915850694

98%

push

github

Delete tabs/related_objects_helper (#4431)

* Delete tabs/related_objects_helper

The 3 helpers it carried were thin adapters around
`Tab::Related::Query`. Two — `related_objects_tab` and
`related_locations_tab` — had no callers left (only docstring
references). The one live caller of `related_images_tab` was
`Tabs::ProjectsHelper#project_observation_buttons`, which only
needed the URL from the legacy `[name, url, opts]` tuple. Sweep
it to call `Tab::Related::Query.for(...)&.path` directly and
delete the helper file.

`Tab::Related::Query`'s docstring loses the references to the
deleted helpers.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Tab::Related::Query: add #path delegating to to_internal_link.url

`Tab::Related::Query` overrides `to_internal_link` rather than
implementing `#path` (the URL is computed inside
`InternalLink::RelatedQuery`). With no override, `#path` inherits
from `Tab::Base` which raises NotImplementedError. CI on the
parent commit reported 3 errors from
`ObservationsControllerIndexTest#test_index_project*` when the
sweep hit `Tab::Related::Query.for(...)&.path`.

Delegate `#path` to the internal link's `#url` so callers that
want just the URL — the only signal the previous
`[name, url, opts]` destructuring extracted — work without
routing through `.to_a`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

3 of 3 new or added lines in 2 files covered. (100.0%)

42147 of 43460 relevant lines covered (96.98%)

681.24 hits per line