MushroomObserver / mushroom-observer / 26912608260

97%

push

github

Tab POROs: name external links + delete object_link_helper URL builders (#4430)

* Tab POROs: name external links + delete object_link_helper URL builders

Migrate the remaining external-site link helpers in
`app/helpers/tabs/names_helper.rb` (eol, gbif, google_name,
inat, ascomycete_org, mushroomexpert, ncbi_nucleotide, wikipedia,
index_fungorum_record, index_fungorum_name_search,
index_fungorum_search_page, mycobank_record, mycobank_basic_search,
fungorum_gsd_synonymy, fungorum_sf_synonymy) to PORO classes under
`Tab::Name::*`, each inheriting from the existing
`Tab::Name::ExternalBase` which carries the shared
`target=_blank` / `rel=noopener` attrs.

`ExternalBase` now accepts `name: nil` so the two search-landing
links (`IndexFungorumSearchPage`, `MycobankBasicSearch`) work
without a Name — `model` returns nil and the rendered link uses
plain `InternalLink` (no per-id selector class).

Caller sweep:

- `_nomenclature.html.erb` — 9 `*_tab` calls → direct PORO
- `_observations_menu.html.erb` — 8 `*_tab` calls → direct PORO
- `test/controllers/names_controller_show_test.rb` — 16 helper-URL
  assertions → `Tab::Name::*.new(...).path`

Helper cleanup:

- `app/helpers/object_link_helper.rb` — delete 17 dead URL builders
  (`gbif_name_search_url`, `mycoportal_url`, `eol_url` via name,
  etc.) plus the `mycobank_host` private constant. File shrinks
  from 234 to 95 lines; surviving methods are the in-app link
  builders (`location_link`, `name_link`, `user_link`,
  `link_to_object`, `observation_herbarium_record_link`, etc.).
- `app/helpers/tabs/names_helper.rb` — delete `external_name_tab`
  + 15 external link tab methods. Only `names_index_sorts`
  remains pending relocation to `app/helpers/names_helper.rb`.

15 new external PORO tests added covering title / alt_title / path
/ model on each, including conditional Google-Search behavior for
"Group" rank.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* object_link_helper: lever co... (continued)

83 of 83 new or added lines in 16 files covered. (100.0%)

42151 of 43466 relevant lines covered (96.97%)

684.24 hits per line