agama-project / agama / 26829461125

83%

push

github

Editorconfig fixes, fixed problems reported by the `shfmt` tool (#3575)

## Problem

- The shell formatting options are not used in the `web/` and `service/`
subdirectories.

## Solution

- Remove `root = true` option from the `.editorconfig` files in
subdirectories, that prevents from using the shared rules from the
top-level `.editorconfig` file, like the `*.sh` definition.
- Added a special `[[shell]]` section for formatting the shell files
using the `shfmt` tool, it can autodetect shell files even without the
`*.sh` extension (it checks the hashbang on the first line). See the
[shfmt
documentation](https://manpages.debian.org/testing/shfmt/shfmt.1.en.html).

## Notes

- Additionally I fixed the most severe issues found by the `shfmt` tool.
- It can be used to reformat the sources into an unified style but to
make only the minimal changes before RC I'm postponing that fixes after
the release. Mostly there is just inconsistent indentation, extra `;`
separators , trailing spaces or similar minor issues. The potentially
serious issues are already fixed in this pull request.

## Testing

- Tested manually, the shell formatting options are correctly applied
also in the `web/` and `service/` subdirectories.

## TODO

- Later I'd like to run the `shfmt` check in the CI, but again, after
the release...

4399 of 6435 branches covered (68.36%)

Branch coverage included in aggregate %.

23858 of 28253 relevant lines covered (84.44%)

97.69 hits per line