agama-project / agama / 26827820465

83%

Build Type

push

github

Committed by web-flow

Commit Message

feat(storage): LVM policy for generating physical volumes (#3549)

New LVM volume groups use the needed space to allocate its logical
volumes. For example, if two disks are selected as target devices for
creating physical volumes and everything fits into the first disk, then
the second disk is not used at all.

This behaviour could be unexpected, so now Agama allows configuring the
policy for creating new physical volumes:

## `useNeeded` policy

This is the policy for the current behaviour. Only needed space is used.
It is the default value to keep backward compatibility with old
profiles.

~~~json
{
  "physicalVolumes": [
    { 
      "generate": {
        "targetDevices": ["disk1", "disk2"],
        "spacePolicy": "useNeeded"
      }
    }
  ]
}
~~~

If a config is loaded using the CLI and `useNeeded` is used, then the UI
will inform to the user, but it does not allow changing the policy. In
this case, the volume group has to be removed and created again in order
to use `useAvailable` policy.

## `useAvailable` policy

Creates the volume group using all the space available in the target
devices. Volume groups created through the UI will always use this
policy.

~~~json
{
  "physicalVolumes": [
    { 
      "generate": {
        "targetDevices": ["disk1", "disk2"],
        "spacePolicy": "useAvailable"
      }
    }
  ]
}
~~~

Coverage Stats

4399 of 6435 branches covered (68.36%)

Branch coverage included in aggregate %.

28 of 28 new or added lines in 9 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

23858 of 28253 relevant lines covered (84.44%)

97.69 hits per line