tomerfiliba / plumbum / 26779518311

88%

push

github

fix: assorted pre-2.0 correctness issues (stem, ssh tunnel timeout, Set completion) (#809)

* fix: address assorted pre-2.0 correctness issues

- machines/ssh_machine: honor the `connect_timeout` argument of
  `SshMachine.tunnel`, which was accepted but ignored (the machine's own
  `connect_timeout` was always used instead)
- path/local, path/remote: `stem` now removes only the final suffix
  (e.g. `archive.tar.gz` -> `archive.tar`) to match `pathlib`/`os.path`,
  instead of stripping every suffix; dotfiles like `.bashrc` keep their name
- cli/switches: `Set.choices` lowercases the partial before prefix-matching
  for case-insensitive sets (so e.g. `--mode TC` completes `TCP`), and
  respects `case_sensitive=True`

Assisted-by: ClaudeCode:claude-opus-4.8

* fix: address PR review feedback on pre-2.0 fixes

- Type tunnel(connect_timeout=...) as float | None to match ShellSession
  and SshMachine.__init__, allowing None to disable the prompt timeout.
- Add RemotePath.stem regression for leading-dot names (.bashrc).
- Add Set.choices() tests covering case-insensitive uppercase partials
  and the case-sensitive path.

Assisted-by: ClaudeCode:claude-opus-4.8

* fix(ssh): default tunnel connect_timeout to machine-level value

Default tunnel(connect_timeout=...) to None and fall back to the
machine-level connect_timeout, so an unspecified per-tunnel timeout no
longer overrides the machine default (addresses PR review).

Assisted-by: ClaudeCode:claude-opus-4.8

1268 of 1724 branches covered (73.55%)

7 of 7 new or added lines in 4 files covered. (100.0%)

5378 of 6179 relevant lines covered (87.04%)

11.45 hits per line