tomerfiliba / plumbum / 26792737627

88%

push

github

fix: make `**` glob recursively like pathlib (#628) (#812)

* fix: make ** glob recursively like pathlib (#628)

The `//` glob operator treated `**` like a single `*`, so recursive
patterns such as `**/*.zip` never descended into subdirectories.

For local paths, pass `recursive=True` to `glob.glob`. For remote
paths, enable bash `globstar` (ignored by shells that lack it) so the
expansion loop recurses too.

Assisted-by: ClaudeCode:claude-opus-4.8

* fix: portable remote recursive glob + docs/tests

The remote glob session runs over /bin/sh (dash on Linux, bash 3.2 on
macOS), neither of which supports ``globstar`` -- so the previous
``shopt -s globstar`` approach never actually recursed. Replace it with
a portable ``find``-based enumeration matched in Python via a new
``_glob_to_regex`` helper that implements pathlib-like ``**`` semantics
(``**`` crosses directories; ``*``/``?`` stay within a segment). This
also avoids the shell-glob quirks that bite paths containing glob
metacharacters.

Add a ``.. versionchanged:: 2.0`` note, an SSH integration test for
recursive remote globbing, and a non-SSH unit test covering the
matcher on every platform.

Assisted-by: ClaudeCode:claude-opus-4.8

* fix: tighten remote glob matcher per review

Address review feedback on the remote recursive glob matcher:

- Treat ``**`` as recursive only when it is a whole path segment
  (``a**b`` is now two ``*`` wildcards within one segment), via
  ``_is_recursive_glob``.
- Support ``[...]`` character classes in glob segments.
- Do not match dotfiles unless the pattern segment starts with a
  literal ``.`` (and ``**`` no longer traverses hidden directories),
  matching ``glob.glob`` -- the local backend.
- Sort recursive results so output order is deterministic across
  platforms, like the shell-expansion and local backends.

Expand the non-SSH unit tests to cover dotfiles, character classes,
and recursion detection.

Assisted-by: ClaudeCode:claude-opus-4.8

* fix: keep partia... (continued)

1298 of 1758 branches covered (73.83%)

56 of 60 new or added lines in 1 file covered. (93.33%)

5434 of 6239 relevant lines covered (87.1%)

11.46 hits per line