tomerfiliba / plumbum / 26779006849

88%

Build Type

push

github

Committed by web-flow

Commit Message

fix: pre-2.0 bug sweep across cli, paths, and commands (#808)

* fix: correct several pre-2.0 bugs across cli, paths, and commands

- cli/progress: format time remaining with `:.0f` instead of `:.0`, which
  rendered estimates in scientific notation (e.g. "1e+01 completed")
- cli/application: initialize `retcode = 0` in `invoke()` so a non-main
  nested command no longer raises `UnboundLocalError`
- cli/terminal: `choose()` honors falsy-but-valid defaults (e.g. 0, "")
  by checking `default is not None`
- path/remote: `RemotePath.suffix` no longer raises `IndexError` on names
  without an extension; uses `os.path.splitext` to match `LocalPath`
- path/remote: fix missing f-string prefix in `symlink` TypeError message
- machines/remote: quote the path in `_path_touch` with `shquote`
- commands/daemons: close pipe fds via try/finally in `posix_daemonize`
  to avoid leaks when the launcher subprocess or read fails
- commands/modifiers: `_TEE` decodes captured output with the command's
  encoding instead of hardcoded UTF-8
- typed_env: make `__iter__`/`__len__` consistent and stop leaking class
  members into iteration in the no-descriptor case

Assisted-by: ClaudeCode:claude-opus-4.8

* test: skip chown tests when new files don't inherit the process gid

`skip_without_chown` only checked `hasattr(os, "chown")`, which is true on
macOS, so `test_chown` ran and failed on its precondition `p.gid ==
os.getgid()`. On BSD/macOS a new file inherits its parent directory's group
(e.g. a wheel-owned TMPDIR) rather than the creating process's gid, so that
assumption does not hold. Detect this empirically and skip both the local
and remote chown tests on such machines while keeping coverage on Linux CI.

Assisted-by: ClaudeCode:claude-opus-4.8

* fix(path): make RemotePath.suffixes consistent with suffix for dotfiles

Use os.path.splitext like LocalPath.suffixes so dotfiles (e.g. .bashrc)
report no suffixes, keeping suffixes consistent with suffix and fixing
with_suff... (continued)

Coverage Stats

1265 of 1720 branches covered (73.55%)

33 of 38 new or added lines in 9 files covered. (86.84%)

6 existing lines in 1 file now uncovered.

5373 of 6174 relevant lines covered (87.03%)

11.45 hits per line