djeedai / bevy_hanabi / 26723758613

58%

push

github

Re-add spawner padding to fix align (#530)

Revert some change removing the `GpuSpawnerParams` padding to GPU device
min storage buffer alignment. Although most shaders use an array of
spawners with an entire buffer binding, `vfx_sort_fill` still binds a
single spawner item. This means we need each element to be aligned to
that GPU device limit. Things were inadvertently working on GPUs with
lower limits (e.g. NVIDIA) because the `GpuSpawnerParams` size was a
multiple of the alignment limit. But on platforms with higher limits
(Metal; 256 bytes) things broke. This change re-add the explicit padding
to restore the proper alignment and fix the indexing.

This fixes the regression added by #525 on macOS.

12 of 14 new or added lines in 5 files covered. (85.71%)

4800 of 8335 relevant lines covered (57.59%)

198.38 hits per line