iotaledger / iota / 26700240572
67%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1074
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 66.909% (+0.01%) from 66.897%
26700240572

push

github

web-flow 
fix(iota-indexer): use lamport-1 for NotYetCreated backward-history rows (#11687)

# Description of change

Switch the not yet created version to `lamport - 1`, matching the unwrap
path and the original design proposal. Each create now results in a
distinct version keeping versions of each object monotonic, so
MIN(version) works properly in the consistent view query.

Add an e2e test exercising create -> delete -> recreate of a DOF across
four checkpoints. The test fails on the old `-1` ingestion (`cv2_after`
returns no edges) and passes with the fix.

## Links to any relevant issues

fixes https://github.com/iotaledger/iota/issues/11686

## How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any
relevant configurations.

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)

### Infrastructure QA (only required for crates that are maintained by
@iotaledger/infrastructure)

- [ ] Synchronization of the indexer from genesis for a network
including migration objects.
- [ ] Restart of indexer synchronization locally without resetting the
database.
- [ ] Restart of indexer synchronization on a production-like database.
- [ ] Deployment of services using Docker.
- [ ] Verification of API backward compatibility.

0 of 1 new or added line in 1 file covered. (0.0%)

57 existing lines in 13 files now uncovered.

152131 of 227369 relevant lines covered (66.91%)

462944.48 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
0.0
 0.0% crates/iota-indexer/src/ingestion/primary/prepare.rs

Coverage Regressions

Lines Coverage ∆ File
31
0.0
 0.0% crates/iota-indexer/src/ingestion/primary/prepare.rs
10
88.12
 -0.95% crates/iota-network/src/state_sync/mod.rs
2
91.09
 -0.09% crates/iota-core/src/authority/authority_per_epoch_store.rs
2
81.59
 -0.06% crates/iota-core/src/authority.rs
2
74.1
 0.29% crates/iota-network/src/randomness/mod.rs
2
66.67
 -4.17% crates/iota-network-stack/src/anemo_ext.rs
2
88.99
 0.0% crates/starfish/core/src/commit_syncer/fast.rs
1
86.11
 -2.78% crates/iota-cluster-test/src/test_case/native_transfer_test.rs
1
89.69
 0.34% crates/iota-core/src/connection_monitor.rs
1
79.56
 -0.12% crates/iota-types/src/crypto.rs
1
96.47
 -0.03% crates/starfish/core/src/dag_state.rs
1
87.84
 0.0% crates/starfish/core/src/leader_timeout.rs
1
75.34
 -0.1% crates/test-cluster/src/lib.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 26700240572.1 1074
66.91
 GitHub Action Run
Source Files on build 26700240572