iotaledger / iota / 26670870516
67%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1074
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 66.897% (+0.02%) from 66.88%
26670870516

push

github

web-flow 
fix(iota-indexer): use lamport-1 for NotYetCreated backward-history rows (#11687)

# Description of change

Switch the not yet created version to `lamport - 1`, matching the unwrap
path and the original design proposal. Each create now results in a
distinct version keeping versions of each object monotonic, so
MIN(version) works properly in the consistent view query.

Add an e2e test exercising create -> delete -> recreate of a DOF across
four checkpoints. The test fails on the old `-1` ingestion (`cv2_after`
returns no edges) and passes with the fix.

## Links to any relevant issues

fixes https://github.com/iotaledger/iota/issues/11686

## How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any
relevant configurations.

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)

### Infrastructure QA (only required for crates that are maintained by
@iotaledger/infrastructure)

- [ ] Synchronization of the indexer from genesis for a network
including migration objects.
- [ ] Restart of indexer synchronization locally without resetting the
database.
- [ ] Restart of indexer synchronization on a production-like database.
- [ ] Deployment of services using Docker.
- [ ] Verification of API backward compatibility.

0 of 1 new or added line in 1 file covered. (0.0%)

1351 existing lines in 49 files now uncovered.

152102 of 227369 relevant lines covered (66.9%)

463357.13 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
0.0
 0.0% crates/iota-indexer/src/ingestion/primary/prepare.rs

Coverage Regressions

Lines Coverage ∆ File
292
12.11
 -0.34% crates/iota-graphql-rpc/src/types/object.rs
190
81.66
 0.19% crates/iota-core/src/authority.rs
120
77.18
 -1.43% crates/iota-core/src/execution_cache.rs
83
84.99
 0.19% crates/iota-config/src/node.rs
83
91.26
 -0.22% crates/iota-core/src/execution_cache/writeback_cache.rs
71
87.19
 -0.01% crates/iota-node/src/lib.rs
57
72.82
 0.87% crates/iota-swarm/src/memory/swarm.rs
50
75.44
 -1.09% crates/test-cluster/src/lib.rs
41
84.77
 0.67% crates/iota-swarm-config/src/node_config_builder.rs
40
0.0
 0.0% crates/iota-graphql-rpc/src/types/address.rs
37
59.22
 -5.96% crates/iota-core/src/authority/epoch_start_configuration.rs
36
81.17
 0.73% crates/iota-swarm-config/src/network_config_builder.rs
33
55.77
 0.0% external-crates/move/crates/move-package/src/lib.rs
28
0.0
 0.0% crates/iota-graphql-rpc/src/types/transaction_block/filter.rs
21
68.6
 -1.37% crates/iota-core/src/authority/authority_store.rs
16
84.49
 -1.98% crates/iota-transaction-builder/src/lib.rs
12
65.38
 0.0% crates/iota-config/src/lib.rs
12
90.26
 0.07% crates/iota-protocol-config/src/lib.rs
11
64.21
 -2.32% crates/iota-types/src/storage/shared_in_memory_store.rs
10
91.53
 1.43% crates/iota-core/src/authority/test_authority_builder.rs
8
54.26
 0.57% crates/iota-json-rpc-types/src/iota_object.rs
7
73.81
 -0.72% crates/iota-network/src/randomness/mod.rs
6
80.46
 0.29% crates/iota-core/src/traffic_controller/mod.rs
6
72.11
 -4.08% crates/iota-json-rpc-types/src/lib.rs
6
44.55
 -0.99% crates/iota-json-rpc-types/src/object_changes.rs
6
91.85
 -4.44% crates/iota-package-management/src/lib.rs
6
88.85
 0.0% crates/iota-test-transaction-builder/src/lib.rs
6
50.0
 -21.43% crates/iota-types/src/collection_types.rs
5
77.37
 0.0% crates/iota-sdk/src/wallet_context.rs
4
83.82
 -0.98% crates/iota-core/src/storage.rs
4
51.88
 -1.37% crates/iota-sdk/src/apis/read.rs
4
58.33
 -33.33% crates/iota-stardust-types/src/block/output/unlock_condition/timelock.rs
4
89.42
 -0.96% crates/iota-types/src/base_types.rs
3
71.43
 -14.29% crates/iota-config/src/certificate_deny_config.rs
3
77.32
 -0.14% crates/iota-core/src/checkpoints/mod.rs
3
82.35
 0.0% crates/iota-genesis-builder/src/stardust/types/output_header.rs
3
49.56
 0.0% crates/iota-genesis-builder/src/stardust/types/snapshot.rs
3
60.26
 0.07% crates/iota-json-rpc-types/src/iota_transaction.rs
3
82.47
 -1.2% crates/iota-metrics/src/histogram.rs
3
95.19
 -2.88% crates/starfish/config/src/committee.rs
3
91.73
 -0.05% crates/starfish/core/src/header_synchronizer.rs
2
87.5
 0.0% crates/iota-common/src/logging.rs
2
91.18
 -0.04% crates/iota-core/src/authority/authority_per_epoch_store.rs
2
89.35
 -0.69% crates/iota-core/src/connection_monitor.rs
2
90.82
 0.42% crates/iota-core/src/epoch/randomness.rs
1
76.79
 -0.24% crates/iota-core/src/authority/authority_store_tables.rs
1
89.08
 0.0% crates/iota-network/src/state_sync/mod.rs
1
52.78
 -2.78% crates/iota-storage/src/package_object_cache.rs
1
93.48
 -0.07% crates/starfish/core/src/transactions_synchronizer.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 26670870516.1 1074
66.9
 GitHub Action Run
Source Files on build 26670870516