26557710163
81%

Ran 28 May 2026 07:06AM UTC

Jobs 1

Files 64

Run time 1min

Badge

Embed ▾

Committed 26 May 2026 03:29PM UTC coverage: 76.295% (+3.2%) from 73.069%

Build # 26557710163

Build Type

push

github

Committed by

web-flow

Commit Message

(2.14) fix: JetStream consumer lock leak on start sequence error (#8230)

## Summary

This PR fixes a lock leak in JetStream consumer creation.

In `addConsumerWithAssignment`, `mset.mu` is held while creating a
consumer. In the direct/standalone path, if `o.selectStartingSeqNo()`
returns an error, the function currently returns without releasing
`mset.mu`.

This adds the missing `mset.mu.Unlock()` before returning the error.

Resolves #8229 

## Impact

Without this unlock, the stream mutex can remain locked after a starting
sequence error, which may cause later operations on the same stream to
block.

## Changes

- Add the missing `mset.mu.Unlock()` before returning from the
`selectStartingSeqNo()` error path.

## Detection

This issue was reported by
[`goconcurrencylint`](https://github.com/sanbricio/goconcurrencylint).

## Testing

- Not added yet. This is a minimal error-path fix identified by static
analysis.

Signed-off-by: Santiago Bricio <sanbriciorojas11@gmail.com>

Coverage Stats

71289 of 93439 relevant lines covered (76.29%)

491131.17 hits per line

Coverage Regressions

Lines	Coverage	∆	File
52	82.4	0.65%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go
32	81.42	0.65%	src/github.com/nats-io/nats-server/server/raft.go
19	87.5	2.42%	src/github.com/nats-io/nats-server/server/consumer.go
13	74.41	11.68%	src/github.com/nats-io/nats-server/server/jetstream_api.go
5	84.54	-0.23%	src/github.com/nats-io/nats-server/server/events.go
2	78.33	1.78%	src/github.com/nats-io/nats-server/server/filestore.go
2	93.44	0.0%	src/github.com/nats-io/nats-server/server/gateway.go
2	84.69	9.73%	src/github.com/nats-io/nats-server/server/jetstream.go
2	98.58	0.0%	src/github.com/nats-io/nats-server/server/jetstream_versioning.go
2	63.05	1.67%	src/github.com/nats-io/nats-server/server/opts.go
1	88.87	0.95%	src/github.com/nats-io/nats-server/server/client.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	26557710163.1	28 May 2026 07:06AM UTC	64	76.29	GitHub Action Run

nats-io / nats-server / 26557710163
81%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 26557710163

nats-io / nats-server / 26557710163 81%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 26557710163

nats-io / nats-server / 26557710163
81%

README BADGES
x