• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

nats-io / nats-server / 26493872893
73%

Build:
DEFAULT BRANCH: main
Ran 27 May 2026 07:08AM UTC
Jobs 1
Files 64
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

26 May 2026 03:29PM UTC coverage: 73.069% (-7.6%) from 80.674%
26493872893

push

github

web-flow
(2.14) fix: JetStream consumer lock leak on start sequence error (#8230)

## Summary

This PR fixes a lock leak in JetStream consumer creation.

In `addConsumerWithAssignment`, `mset.mu` is held while creating a
consumer. In the direct/standalone path, if `o.selectStartingSeqNo()`
returns an error, the function currently returns without releasing
`mset.mu`.

This adds the missing `mset.mu.Unlock()` before returning the error.

Resolves #8229 

## Impact

Without this unlock, the stream mutex can remain locked after a starting
sequence error, which may cause later operations on the same stream to
block.

## Changes

- Add the missing `mset.mu.Unlock()` before returning from the
`selectStartingSeqNo()` error path.

## Detection

This issue was reported by
[`goconcurrencylint`](https://github.com/sanbricio/goconcurrencylint).

## Testing

- Not added yet. This is a minimal error-path fix identified by static
analysis.

Signed-off-by: Santiago Bricio <sanbriciorojas11@gmail.com>

68275 of 93439 relevant lines covered (73.07%)

488352.47 hits per line

Coverage Regressions

Lines Coverage ∆ File
2052
25.83
-50.23% src/github.com/nats-io/nats-server/server/mqtt.go
759
75.78
-10.11% src/github.com/nats-io/nats-server/server/stream.go
679
76.55
-1.82% src/github.com/nats-io/nats-server/server/filestore.go
512
69.79
-17.72% src/github.com/nats-io/nats-server/server/monitor.go
477
62.73
-12.45% src/github.com/nats-io/nats-server/server/jetstream_api.go
457
85.09
-2.65% src/github.com/nats-io/nats-server/server/consumer.go
449
80.78
0.23% src/github.com/nats-io/nats-server/server/raft.go
393
75.75
-14.06% src/github.com/nats-io/nats-server/server/leafnode.go
336
66.28
-16.21% src/github.com/nats-io/nats-server/server/memstore.go
286
78.16
-8.32% src/github.com/nats-io/nats-server/server/accounts.go
271
43.75
-22.89% src/github.com/nats-io/nats-server/server/websocket.go
241
41.91
-14.77% src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
209
74.97
-9.73% src/github.com/nats-io/nats-server/server/jetstream.go
169
61.38
-3.39% src/github.com/nats-io/nats-server/server/opts.go
154
75.94
-12.11% src/github.com/nats-io/nats-server/server/auth.go
144
49.33
-7.47% src/github.com/nats-io/nats-server/server/reload.go
113
85.46
-3.51% src/github.com/nats-io/nats-server/server/server.go
108
2.75
-59.34% src/github.com/nats-io/nats-server/server/cron.go
107
87.92
-2.19% src/github.com/nats-io/nats-server/server/client.go
105
81.76
-0.59% src/github.com/nats-io/nats-server/server/jetstream_cluster.go
84
48.05
-16.41% src/github.com/nats-io/nats-server/server/dirstore.go
63
43.98
-32.98% src/github.com/nats-io/nats-server/server/jwt.go
63
82.04
-0.77% src/github.com/nats-io/nats-server/server/route.go
57
84.02
-7.29% src/github.com/nats-io/nats-server/server/jetstream_batching.go
53
51.46
-11.09% src/github.com/nats-io/nats-server/server/subject_transform.go
42
6.67
-93.33% src/github.com/nats-io/nats-server/server/monitor_sort_opts.go
33
35.38
-50.77% src/github.com/nats-io/nats-server/server/feature_flags.go
28
55.49
-15.38% src/github.com/nats-io/nats-server/server/log.go
26
88.82
-2.17% src/github.com/nats-io/nats-server/server/sublist.go
20
84.77
-0.84% src/github.com/nats-io/nats-server/server/events.go
20
80.97
-1.89% src/github.com/nats-io/nats-server/server/parser.go
19
77.15
-7.12% src/github.com/nats-io/nats-server/server/scheduler.go
18
75.6
-5.36% src/github.com/nats-io/nats-server/server/store.go
9
84.43
-3.28% src/github.com/nats-io/nats-server/server/util.go
5
74.07
-6.17% src/github.com/nats-io/nats-server/server/errors.go
4
72.01
-0.9% src/github.com/nats-io/nats-server/server/avl/seqset.go
3
93.44
-0.12% src/github.com/nats-io/nats-server/server/gateway.go
2
98.58
0.0% src/github.com/nats-io/nats-server/server/jetstream_versioning.go
Jobs
ID Job ID Ran Files Coverage
1 26493872893.1 27 May 2026 07:08AM UTC 64
73.07
GitHub Action Run
Source Files on build 26493872893
  • Tree
  • List 64
  • Changed 38
  • Source Changed 7
  • Coverage Changed 38
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #26493872893
  • a948cef0 on github
  • Prev Build on main (#26435225498)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc